Mark as compatible with Webpack 3 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the package as compatible with Webpack 3. npm refuses to install if using webpack 3, even everything seems to work fine
halfzebra
reviewed
Jun 25, 2017
| }, | ||
| "peerDependencies": { | ||
| "webpack": "1 || 2" | ||
| "webpack": "1 || 2 || 3" |
There was a problem hiding this comment.
1 - 3 semver range would probably be more succinct 🤔
Contributor
Author
There was a problem hiding this comment.
TIL that's a thing you can do
|
Time to merge! : ) |
Owner
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the package as compatible with Webpack 3.
npm refuses to install if using webpack 3, even everything seems to work fine